Yanming Zhou

icon indicating an email [email protected]

icon company I'm open to new opportunities icon location Changsha, China icon location Active open source contributor, top contributor of Spring Ecosystem & Hibernate ORM

Results 241 comments of Yanming Zhou
trafficstars

MSSQL Server connection goes to sleeping state and blocking another queries

@ravirajsinh-lab I created https://github.com/brettwooldridge/HikariCP/pull/2247 to allow configuring `closeTimeout`.

Fallback to default fragment implementation if no candidates found

Any thoughts?

Fallback to default fragment implementation if no candidates found

> Falling back to a same-package default implementation deviates from what Spring's approach and seems a bit random. Same-package default implementation is unique, could you explain why it's random? Specifying...

Remove duplicated spaces before `when matched`

Could you review this also? @gavinking

Remove duplicated spaces before `when matched`

> If I'm not mistaken, there appears to be a similar problem in `SqlAstTranslatorWithUpsert`. Could you take a look at that one too, please? Indeed, I've fixed that also.

Let `spring.profiles.[include|active]` accept list as well as comma separated value in bootstrapProperties

It fix https://github.com/spring-cloud/spring-cloud-commons/issues/1329 also.

Let `spring.profiles.[include|active]` accept list as well as comma separated value in bootstrapProperties

Could any team member review?

HHH-15422 Pick up `CurrentTenantIdentifierResolver` and `MultiTenantConnectionProvider` from BeanContainer if not explicit set

Could you review this also? @gavinking

HHH-15422 Pick up `CurrentTenantIdentifierResolver` and `MultiTenantConnectionProvider` from BeanContainer if not explicit set

> So it turns out that my objections to this pull request actually boil down to only the following, which occurs in two places: > > ```java > @Override >...

HHH-15422 Pick up `CurrentTenantIdentifierResolver` and `MultiTenantConnectionProvider` from BeanContainer if not explicit set

> > it will create two instances > > It will create one instance per persistence unit, which is _completely_ fine. Take spring for example, I mean one instance for...