Yanming Zhou comments

Results 241 comments of


                                            Yanming Zhou

trafficstars

Use JDBC driver-provided named prepared statements if available

> Note: JDBC specifies 6 prepareStatement methods (e.g. autogeneratedKeys, resultsettype, holdability, and so on), so if we go with adding PlaceholderStyle parameter, we would have to add 6 new prepareStatement...

Use JDBC driver-provided named prepared statements if available

> Based on my current understanding, "auto detect" is likely not an option as it might create subtle parsing issues. For instance, with "positional" (JDBC) style, one has to duplicate...

Use JDBC driver-provided named prepared statements if available

> The query might contain no placeholders at all in which case you won't be able to tell if it is "positional or named". Then use positional as default because...

Why do Session Settings get reset on a connection?

It seems that pgjdbc only support `ApplicationName` as name. https://github.com/pgjdbc/pgjdbc/blob/2f7511504c8eff34e55ed4b72df369687a09e3a8/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java#L1562-L1601

HHH-18027 Clear expansions after JdbcParameterBindings created to allow query reusing

Could someone review this?

HHH-18073 `BasicCollectionJavaType::wrap` should retain order of `Set` to keep consistent with `deepCopy`

Could someone review this?

HHH-18012 Fix array type matching for auto applying AttributeConverter

Could someone review this?

HHH-17840 Fix inconsistency of read/write null JsonNode/JsonValue

ping

Sorting of Pageable.unpaged(sort) is ignored by JPA Repository

I think it's reasonable, It's better to submit a PR instead.

Polishing `SimpleJpaRepository`

> overlaps partially with #3468 You could merge any one first, I will rebase the other one later.