Yanming Zhou

Results 241 comments of Yanming Zhou
trafficstars

> Is using `statement.setMaxRows(1); // limit max rows to 1` somehow equivalent to something like `LIMIT 1`? I think most JDBC drivers honer the max rows. > I don't know...

As you can see, the exception is caused by: ``` Caused by: java.lang.NullPointerException at java.base/java.util.Objects.requireNonNull(Unknown Source) at java.base/java.util.TreeMap.put(Unknown Source) at java.base/java.util.TreeMap.put(Unknown Source) at com.mysql.jdbc.Util.resultSetToMap(Util.java:508) at com.mysql.jdbc.ConnectionImpl.buildCollationMapping(ConnectionImpl.java:1004) ... 25 more ```...

It's fixed by https://github.com/spring-cloud/spring-cloud-commons/pull/1464.

`EntityWithCollectionReloadCacheTest` failed with Sybase, I don't think it's caused by this PR. ``` java.lang.IllegalArgumentException: Expecting 8 byte values to construct a long at org.hibernate.internal.util.BytesHelper.asLong(BytesHelper.java:117) at org.hibernate.type.descriptor.java.UUIDJavaType$ToBytesTransformer.parse(UUIDJavaType.java:160) at org.hibernate.type.descriptor.java.UUIDJavaType.wrap(UUIDJavaType.java:87) at org.hibernate.type.descriptor.java.UUIDJavaType.wrap(UUIDJavaType.java:23)...

It caused by `FragmentMetadata::getFragmentInterfaces` doesn't consider indirect super interfaces. https://github.com/spring-projects/spring-data-commons/blob/4718c454ae04a66679ef159f0ae2d2bbaec9c8b4/src/main/java/org/springframework/data/repository/config/FragmentMetadata.java#L51-L57 I'll try to fix it later.

> Disable log4j2 for client component. Is there a way to disable logging for particular lib except increasing logging level threshold? > Increase the capacity of RingBuffer. Not an option,...

Thanks for your quick response. Currently I'm setting `log4j2.contextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector`, and using two type of appenders, `RollingFile` for local file and `Kafka` for centralized log collection, I think [Mixed sync/async](https://logging.staged.apache.org/log4j/2.x/manual/async.html#MixedSync-Async) is...

> `log4j2.asyncLoggerSynchronizeEnqueueWhenQueueFull` to `false`. The correct system property key is `AsyncLogger.SynchronizeEnqueueWhenQueueFull`.