hibernate-orm icon indicating copy to clipboard operation
hibernate-orm copied to clipboard

Remove duplicated spaces before `when matched`

Open quaff opened this issue 1 year ago • 1 comments
trafficstars

Running org.hibernate.orm.test.stateless.UpsertTest:

Before -> merge into "UpsertTest$Record" as t using (select cast(? as bigint) id, cast(? as varchar) message) as s on (t.id=s.id) when not matched then insert (id, message) values (s.id, s.message) when matched then update set message=s.message After -> merge into "UpsertTest$Record" as t using (select cast(? as bigint) id, cast(? as varchar) message) as s on (t.id=s.id) when not matched then insert (id, message) values (s.id, s.message) when matched then update set message=s.message

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion. For more information on licensing, please check here.


quaff avatar Aug 20 '24 09:08 quaff

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+     ↳ Offending commits: [ba0971816faa696473ab0a62716963c04cb643b0]

› This message was automatically generated.

Could you review this also? @gavinking

quaff avatar Aug 29 '24 02:08 quaff

If I'm not mistaken, there appears to be a similar problem in SqlAstTranslatorWithUpsert. Could you take a look at that one too, please?

Indeed, I've fixed that also.

quaff avatar Aug 29 '24 08:08 quaff

Great, thank you!

gavinking avatar Aug 29 '24 08:08 gavinking