Yanming Zhou comments

Results 241 comments of


                                            Yanming Zhou

trafficstars

Document that username and password are not used when 'spring.data.redis.url' is set

> Configuration via URL doesn't allow username and password to be passed separately. This is problematic in a prod environment where these data need to be encrypted. You can use...

Resolve nested placeholders as possible if value is CharSequence

Please note the argument at [Spring Framework side](https://github.com/spring-projects/spring-framework/pull/32876#issuecomment-2128780258).

Resolve nested placeholders as possible if value is CharSequence

> Please note the argument at [Spring Framework side](https://github.com/spring-projects/spring-framework/pull/32876#issuecomment-2128780258). Resolved by not resolving nested placeholders if value is instance of `targetValueType`.

Review spring.jpa.database and spring.jpa.database-platform and their standard JPA equivalents

Please note currently it's not full supported by EclipseLink, see https://github.com/jakartaee/persistence/issues/628#issuecomment-2132961699.

HHH-18282 fix generate error sql in case of @DiscriminatorValue("not null")

Then `or thp1_0."product_type" in ('1', '2')` is redundant, your fix should eliminate that.

Support JSON Pointer in @HttpExchange interface

It seems JSONPath is more popular, It would be nice both are supported.

HHH-18475 fix race condition in AbstractRowReader (Hibernate 5.6)

Good catch.

Improve performance of `JdbcStepExecutionDao::getLastStepExecution`

Alternatively, we could use `SE.STEP_EXECUTION_ID IN (SELECT MAX(STEP_EXECUTION_ID) FROM ...)` to align with other queries, but there is a risk to break existing behavior since `CREATE_TIME` is not considered for...

Improve performance of `JdbcStepExecutionDao::getLastStepExecution`

> The suggested change is basically a revert of the fix for #4657. > > I'm not sure whether the performance gain is worth it, compared to the risk of...

Improve performance of `JdbcStepExecutionDao::getLastStepExecution`

> Our DBA has not been able to find a solution to improve the performance with an additional index. What we did find out is that, by removing the ORDER...