Yanming Zhou

> > it will create two instances > > You need _what_ to be a singleton? The proposed `CurrentTenantIdentifierResolver` and `MultiTenantConnectionProvider`.

> as that class can implement `Configurable` and get injected with PU-specific config. OK, I get the point, I changed `useJpaCompliantCreation()` to return `true`, please review.

> https://hibernate.atlassian.net/browse/HHH-18461 Comment from @beikov : >> We don't want to treat the 0 value specially, since the presence of the offset clause regardless of the value that is bound...

@beikov Please make the call.

> Yeah, the change looks good to me. Please rebase and then we can merge it. Rebased.

I tackled it by: ```java if (ClassUtils.isPresent("org.springframework.boot.devtools.RemoteSpringApplication", DemoApplication.class.getClassLoader())) { String profiles = System.getProperty(ACTIVE_PROFILES_PROPERTY_NAME); if (profiles == null) { profiles = System.getenv(ACTIVE_PROFILES_PROPERTY_NAME.replaceAll("\\.", "_").toUpperCase()); if (profiles == null) { System.setProperty(ACTIVE_PROFILES_PROPERTY_NAME, "dev"); }...

> Would it be possible to handle sorted unpaged pagables as well? Thanks for your suggestion, I've updated the PR.

I'm not sure it should be `s` or `(s)`, the former is more common, but the latter used in this project.

> @quaff Can you please add a link to the Jira issue in the PR description? Thanks. https://hibernate.atlassian.net/browse/HHH-18415

The name is ambiguous, but you can refer to the Javadoc, it states `wait for a connection from the pool` : https://github.com/brettwooldridge/HikariCP/blob/80d30d34c91fa5a2ac3757c6f61cb3177ddc4018/src/main/java/com/zaxxer/hikari/HikariConfigMXBean.java#L29