Jarek Potiuk comments

Results 1574 comments of


                                            Jarek Potiuk

expand_kwargs does not preserve templates

> in this case data author could include {{ var.value.get('SOME_SECRET') }} template and get access to the variable if the target storage is available for them Yes. But you could...

Clean up the exception handler when run_as_user is the airflow user

Nice catch. Can you add a test case for that ?

[Experiment] Use `importlib` import mode for `pytest`

interesting . I had no idea pytest is doing that.

[Experiment] Use `importlib` import mode for `pytest`

> path = sys.path[0] + "/tests/providers/cncf/kubernetes/pod.yaml" Yeah. Someone took advantage of assuming sys.path will be modified :)

Add rpc server to helm chart

Agree `RPC server` is a better name. Also marking it as private (how?) is a good idea.

Add rpc server to helm chart

Why not. It will also be disabled by default so no big deal and we still have the feature flag `AIRFLOW_ENABLE_AIP_44` set to False by default that prevents the component...

Merge kubernetes pod objects inplace

> what do you mean by breaking IMHO it's just broken, not breaking - because it's impossible to foresee how one pod executing will impact another one, and since you...

Build correct SQLAlchemy URI in hooks based on `DbApiHook`

> Hey Andrey think there is some confusion here. Yes we should definitly leave the get_uri method as it is (not get_url as it doesn’t exist yet) and implement a...

Fix in decorators to log dag-id during delete dag-run action #36057

Could you please add a little more description in the commit what problem it fixes - just reference to an issue is not enough - when we merge the commit,...

Microsoft Azure Connection: Service principal secret does not get masked when providing connection via URI environment variable

Looks like duplicate fixed in 2.8.2 @zwelgbeer - > Please upgrade your airflow to latest version and report back. Good idea is to upgrade to