Jarek Potiuk

Results 1573 comments of Jarek Potiuk

> I'm not even sure how to find where or how the change to charset_normalizer impacted this. My solution for now has been to pin requests to 2.25.1. You can...

> Thanks, it works with `[use_chardet_on_py3]`. I still don't see how this sub-dependency can have this impact. Using the charset-normalizer was done in backwards-compatible way to give people who implicitly...

> @Gagaro `html5lib` optionally requires `chardet` and likely behaves differently if it's not installed. Ah. So requests is not the only one with optional chardet dependency :)

Just install `chardet`. And yeah. I think requests maintainer want to remove both in the future.

I think having checks auto-completable is the only actual reason for implementing autocomplete. I love autocomplete, but pre-commit has very small number of options and it's easy to learn them,...

> I disagree: I’m lazy and would like to type `pre- au` The `pre-` comes out of the box, no need for that. But yeah for all other commands would...

Yep fully agree with sequence and caching. Caching will work - we can even cache it in the same place where pre-commit virtualenvs are cached.

> no that won't work, the pre-commit cache is shared and the data you'd be caching would be repository-specific Ah I see, I have not looked in detal. I thought...

> installation is never based on the repository under test -- only the contents of the `.pre-commit-config.yaml`. the cache is carefully maintained by the inputs to taht Then using hash...

> that'd be a hack at best -- while collisions are unlikely it would be very difficult to inspect and debug the actual contents Then we can store it in...