Fix in decorators to log dag-id during delete dag-run action #36057

[sachinp97]

closes: #36057

---

The changes include fix for issue#36057 to add dag-id to the audit logs whenever a dagrun is deleted. A unit test case is included to test if the changes are working or not.

^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[boring-cyborg[bot]]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

[potiuk]

Could you please add a little more description in the commit what problem it fixes - just reference to an issue is not enough - when we merge the commit, it's good to see what problem it solves from just commit message. The issue might be removed or disappear but the commit message will remain (and you will see what it is about without having to look elsewhere)

[sachinp97]

Updated the description to indicate the intent

[bbovenzi]

Do we use AirflowModelView.delete anywhere else? Or will pk always be a DagRun.id?

[vchiapaikeo]

Do we use AirflowModelView.delete anywhere else? Or will pk always be a DagRun.id?

Yea, I think this is problematic because AirflowModelView.delete is used in several other places. For example, when I try to delete a TaskInstance, I am hit w/ this exception:

[sachinp97]

Do we use AirflowModelView.delete anywhere else? Or will pk always be a DagRun.id?

Yea, I think this is problematic because AirflowModelView.delete is used in several other places. For example, when I try to delete a TaskInstance, I am hit w/ this exception:

Good catch @bbovenzi and Thanks @vchiapaikeo for suggested solution. Although this works, it makes decorators bit clumsy with checks for specific use-cases. What do you think?

[eladkal]

@sachinp97 are you still working on this PR?

[github-actions[bot]]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.