Jarek Potiuk
Jarek Potiuk
conflicts to solve?
I would love to have some more reviews on that one - to see if no-one can see a side effect (I believe it is safe to retry on the...
Anyone :) ?
That looks good in general, but before we geto more detailed review we need some unit tests on it (as for any other new code).
Also - we should make the Generic Transfer from `airflow.operatror` deprecated as this is a superset of the Generic Transfer (and common.sql is way better place for such a generic...
Explanation of the `mypy` problem: The MyPy Issue is because for DBApiHook we have a .pyi interface as well defined (to flag any case where we change the interface. See...
How about extracting the common code for version check? Sounds reasonable to do it now?
> Probably yes. How to perform that? Just the usual "Refactor -> Extract" - both are in common.sql provider, so adding `common.sql.util` package with `provider_compatibility.py` and moving the common code...
If you tag me - you limit your chances of getting review. I might be busy/not available or simply not have anything to say I suggest you continue asking for...
Yeah. Most of them comparing tuples to lists :) but a few require closer look. I like some of those ruff checks :)