Patrick Ohly

Results 1004 comments of Patrick Ohly

> Approval from the corresponding SIG is required as well That's not specific to code freeze, but doesn't hurt to call out. I would reorder the two points (first lgtm/approve...

/reopen According to https://github.com/kubernetes-sigs/prow/pull/558#issuecomment-3610818559 the change should have been deployed two days ago in https://github.com/kubernetes/test-infra/pull/36014, but recent PRs still only mention "test freeze" and none of the new hints about...

> @pohly can you fix or remove the pull-kubernetes-kind-classic-dra job? I need it to test the new feature gate in https://github.com/kubernetes/kubernetes/pull/125488. Please ignore it for a few more days (fingers...

I agree, this seems to be it. The goroutines run in a synctest bubble, but when two work items are in the queue the two workers still run with no...

/reopen DRA is also affected by this because resource tracking depends on not removing pods prematurely before the node is done with them. I got bitten by this three years...

FWIW, both better docs and the warning would have helped me: I was looking up the documentation to find the exact field name and then used kubectl where the warning...

> `--sem-ver-filter="kubelet=1.35.0, kube-apiserver=2.3.4, etcd=3.4.5` That seems easy enough to parse. Please also allow a trailing comma (`--sem-ver-filter="kubelet=1.35.0,`). It's easier to compose such a string when each component may be followed...

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/135395/pull-kubernetes-verify/1991933383281741824: ``` Test files may not access mutable global feature gates directly: pkg/controller/devicetainteviction/device_taint_eviction_test.go:// we cannot change them in an init function with utilfeature.DefaultMutableFeatureGate.SetFromMap Use this invocation instead: featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.,...