utils icon indicating copy to clipboard operation
utils copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Deprecate integer min/max functions

Open skitt opened this issue 1 year ago • 7 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Go 1.21 provides min/max builtins. New code going into other Kubernetes repositories (requiring Go 1.21 or later) should use those instead.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

The integer min/max functions are deprecated; the builtin min/max functions in Go 1.21+ should be used instead for new code.

skitt avatar Nov 24 '23 09:11 skitt

@pohly are the deprecation notes clear enough?

skitt avatar Nov 24 '23 09:11 skitt

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 27 '24 13:02 k8s-triage-robot

/remove-lifecycle stale

skitt avatar Mar 04 '24 08:03 skitt

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 02 '24 09:06 k8s-triage-robot

/remove-lifecycle stale

skitt avatar Jun 03 '24 07:06 skitt

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 01 '24 08:09 k8s-triage-robot

/remove-lifecycle stale /lgtm /assign @dims

For approval.

pohly avatar Sep 02 '24 06:09 pohly

/approve /lgtm

dims avatar Sep 21 '24 02:09 dims

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pohly, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 21 '24 02:09 k8s-ci-robot