kubernetes
e2e-tests.md: update description of labels
This explains how to use --filter-label (possible since Kubernetes 1.29) and clarifies the usage of feature gate labels.
/hold
The Feature:Alpha and Feature:Beta documented here gets introduced in https://github.com/kubernetes/kubernetes/pull/124350, which is not merged yet.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pohly
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~contributors/devel/sig-testing/OWNERS~~ [pohly]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold
The intent is that adding tests with only a FeatureGate label is sufficient. Before we allow such tests, we have to do some preparations - see checklist in description.
do we want to merge and do the modifications or do the modifications and then merge based on the feedback?
do we want to merge and do the modifications or do the modifications and then merge based on the feedback?
As the text stands right now, it says (or implies?) that "annotating a test which depends only on a feature gate with only FeatureGate is okay". That is not true yet because most of our jobs would then run that test.
We could merge it now if we added a comment saying that this is the goal but that "as a stop-gap solution, tests which depend on a feature gate also need to be annotated with a feature". It's probably worth explaining that and merge, because then the rest of the new documentation, in particular the part about label filtering, is what people will see when they check the master branch. Agreed?
@aojea: I added such an explanation to the Alpha/Beta section. This is therefore ready for merging.
Sorry, I had already lifted the hold because the reason there no longer applied. I hadn't considered that I self-approve in this repo.
Let's give @danwinship @BenTheElder @SergeyKanzhelev time until Wednesday to comment and suggest further changes before I send a mail to [email protected] about this.
Let's give @danwinship @BenTheElder @SergeyKanzhelev time until Wednesday to comment and suggest further changes before I send a mail to [email protected] about this.
it got merged :) ... we can always amend changes or modify, is not that this is set in stone