Patrick Ohly
Patrick Ohly
Both of these other alternatives sound better to me, in particular adding `Equal` because it wouldn't need changes in apps. I might try to drive adding `atomic/sync.Equal` but if someone...
After thinking about `Equal` a bit more, I am not sure how `atomic/sync` could implement it in a way that would match how `cmp` handles plain pointers. What `sync.Pointer` can...
I suspect `fmt.Sprint` will lead to very unreadable formatting of more complex types and not work well in combination with `cmp.Diff` - think of `atomic.Pointer[SomeStruct]`, not `atomic.Pointer[int]`.
Also, `x.Load() == y.Load()` would compare the pointers for `atomic.Pointer[T any]`, not the `T` values that are being pointed to. `*x.Load() == *y.Load()` wouldn't compile because `T` is not required...
Doesn't `cmp.Diff` already have an opinion about what equality of plain pointer fields means (compare nil vs non-nil, then what's being pointed to)? Doing the same for `atomic.Pointer` IMHO would...
Note that https://github.com/thomasloven/lovelace-card-mod needs to be installed for that, for example via HACS. I did that, but I am unsure where I should place that snippet. I tried both at...
@mkanet: as you [had this working](https://github.com/reptilex/tesla-style-solar-power-card/issues/163#issue-1955772955), can you clarify where to put that `card_mod` snippet?
Solved: when the zoom factor is too high, some other mechanism kicks in and scales back. With `zoom: 1.1` I got a slightly larger card.
See https://community.home-assistant.io/t/solar-power-dashboards-with-sonnenbatterie-10/631443/3 for a more complete description of my setup and screenshots.
I added "register: mppt_1_voltage" and "register: mppt_2_voltage", otherwise loading the config failed. But I am not sure whether it's working: ``` 2023-10-18 06:20:40 DEBUG Changing transaction state from 'PROCESSING REPLY'...