Patrick Ohly
Patrick Ohly
/lgtm /assign @bowei For approval.
This is sanity checking the function's parameters and never gets triggered, otherwise we would have seen the failures, i.e. it doesn't matter. I think returning an error is a better...
@bowei : you had suggestions regarding the key naming. Are you okay with the result?
The correct approach would be to verify with @bowei that the PR is okay now and merge it before doing further work in this area. Let me try lazy consensus:...
FWIW, I also wouldn't mind changing the behavior so that if `Spec.TerminationGracePeriodSeconds` is used as default and happens to be zero, then one would be used instead of zero. I'd...
Thanks @aojea. That other PR shows that the current behavior is unintentionally and should be changed. Let's put this doc update on hold and instead see whether we can finish...
> Those gojsonschema and related packages are often considered problematic because they do not seem to be actively maintained. Even without that concern it is better to not pull in...
@saschagrunert: thanks. Is there a chance to get this into a tagged release soon(ish)?
/assign @pohly /sig node
@ahg-g: with discussion issue you mean a separate issue in some repo (where?) in which arbitrary comments are welcome? No, not at the moment. I've also not seen that done...