Patrick Ohly

Results 1004 comments of Patrick Ohly

Moving all of these functions around will break compilation of downstream test suites. It's worth calling out that the script from the commit message in https://github.com/kubernetes/kubernetes/pull/112043/commits/9c755e01db11a31f40283c221627e8afd9ea505c can be used to...

@aojea: do you agree that this is going in the right direction? I think @spiffxp wanted to get some additional opinions.

Rebased - quick, someone please LGTM it while it is still fresh :sweat_smile:

The best solution that I could come up with that doesn't depend on ResourceVersion is this: - before retrieving an object from the cache with the intent to modify it,...

There is a simpler solution that achieves the same: `Assume` must be passed the original object (= the one retrieved from the cache) and the modified one (= the one...

Let me quote from [the comment](https://kubernetes.slack.com/archives/C09QZFCE5/p1662309741003889?thread_ts=1662018803.454889&cid=C09QZFCE5) from @cofyc in #sig-storage: > Although [the doc about resource version](https://kubernetes.io/docs/reference/using-api/api-concepts/#resource-versions) asks not to compare resource version, however the GET/WATCH methods can accept `ResourceVersion`...

> alphanumeric ordering That would imply padding the integer with enough zeros to ensure that "01" < "20". Not sure whether it can be done on-the-fly for existing objects. How...