Patrick Ohly
Patrick Ohly
> Are you hoping to see the entire failure in the GinkgoWriter log? Yes. The way I see it, analysis of failures in Kubernetes goes like this: - test failures...
> To that end - I'd like to ship the timeout/interrupt/context stuff that's been done so far and then work on this timeline piece as a separate unit of work,...
I don't see `StopTrying` in https://github.com/onsi/gomega/commits/master yet?
I don't think it is important.
We probably need a list of all pending PRs that address the issues found by this tool update. Here are some that I am aware of: - https://github.com/kubernetes/kubernetes/pull/112670 - https://github.com/kubernetes/kubernetes/pull/110747
I already discussed it with him on Slack: https://kubernetes.slack.com/archives/C09QZ4DQB/p1661356920849319
This is no longer WIP: I went ahead and fixed all imports, plus adapted some paths elsewhere. However, https://github.com/kubernetes/kubernetes/pull/111998 should get merged first because this PR is based on it.
This PR currently includes changes at the beginning that were needed but have been merged in some slightly different form through different PRs. Only the commits starting with "[e2e framework:...
Actually, rebasing wasn't too bad. I've done it now.
> I know this will get caught in rebase if it hangs out too long. Yes, I had to rebase again today :sweat_smile: This makes a comparison against the revision...