Patrick Ohly

Results 1002 comments of Patrick Ohly

The benchmark is in PR #706. Here's a preliminary patch for using patching (sic!): ```diff diff --git a/pkg/capacity/capacity.go b/pkg/capacity/capacity.go index 815b00679..8516164dd 100644 --- a/pkg/capacity/capacity.go +++ b/pkg/capacity/capacity.go @@ -25,6 +25,7 @@...

> Additionally, our code will be easier to test if functions like Run() wait for their child goroutines to exit before returning themselves. Just to be sure that I understand...

/reopen /remove-lifecycle rotten /lifecycle frozen /help wanted

Note that the test is currently disabled (https://github.com/kubernetes-csi/csi-test/pull/226) because it was so problematic.

One possible solution is to set a finalizer for the PVC *before* issuing the CreateVolume call and removing it *after* creating the PV.

/remove-lifecycle stale /lifecycle frozen

There's no perfect protection against user mistakes. If a user force-deletes or removes finalizers, they need to be aware that they are working against the system and accept the consequences.

Isn't the storage provisioner charging the user for such a leaked volume? If they can't do that, then they shouldn't grant their untrusted users the permission to create or modify...

/remove-lifecycle rotten