Patrick Ohly

Results 1002 comments of Patrick Ohly

/remove-lifecycle stale /remove-lifecycle rotten /lifecycle frozen Not sure whether anyone is ever going to review this, but let's keep it open until then...

For PMEM-CSI, the functionality to create a namespace of exactly the requested size would have to be in libndctl. That's what we are using, not the code layered on top...

FYI, in PMEM-CSI we started using the same approach as the current `ndctl create-namespace --size`: the size refers to how much PMEM is consumed from the region, not the size...

> The k8s.io/klog package logs panics it observes to stderr, and Ginkgo apparently prints that even when the test passes. It's the runtime which calls klog.Error, which then seems to...

> I've adapted the test scripts to install the ginkgo cli automatically and to copy the unit test report to the correct location for prow FYI, it is possible to...

> The issue with that was that it made the tests always exit with rc0 even when there are failures Which of the two options? `-ginkgo.junit` or adding some custom...