Antoine Pitrou
Antoine Pitrou
@wjones127 These numbers are for the random or monotonic use case?
It sounds like it would be better to document the existing predicates, rather than add new ones with different names.
> The existing set of predicates is both confusing and incomplete, so I'd argue for both documenting and adding predicates Hmm... can you point out the causes for confusion? Perhaps...
Ok, so there are two different areas here: 1) complete and/or fix the set of predicates operating on a `Type::type` parameter 2) add a separate set of predicates operating on...
Also, for the record, functions such as `PrimitiveTypes()` were added for testing originally, and they were exposed publicly because there didn't seem to be a strong reason against it (the...
Now to answer the problems with the current predicates: * +1 to adding `is_numeric`, `is_binary`, `is_string`, `is_temporal` and `is_interval` * for `is_primitive`: is "primitive" any type that's not nested nested/compound;...
Sorry for the delay @rtpsw . I rebased from master and did a couple of very minor changes.
Will wait for CI now...
@lidavidm Since this is a draft, are you looking for a detailed review or more for general opinions?
@lidavidm I don't have time for a second look, unless you really need it :-)