Antoine Pitrou

Results 822 comments of Antoine Pitrou

@prashantkhoje Sorry for the delay. Can you try to get a gdb backtrace from the coredump file?

@westonpace @bkietz Why exactly does `ScannerBuilder` allow setting the same things that can be set in `ScanOptions`?

> Don't think the failed checks have anything to do with me. Indeed, they don't.

@marsupialtail Would you like to address @westonpace 's suggestions? Then I think we're good to go.

By the way, this PR addresses `RecordBatchFileReader` but not `RecordBatchReader`. Do you plan to do that as well?

@niyue Sorry for the late replay, but the C++ `RecordBatchReader` already has a method `Result ReadNext()`, so you wouldn't need to add anything more to the C++ side AFAICT?

@niyue Are you planning to work on this? Otherwise @milesgranger you might be interested in taking this up?

@niyue If/when this is ready for review, please say so :-)

@niyue Sorry, I had overlooked it. I'll take a look when I can. @jorisvandenbossche would you like to review this too?