Antoine Pitrou
Antoine Pitrou
@ZMZ91 I could, but the first step would be to get the CI runs fixed. In addition, since this claims to fix a bug, there should be a unit test...
You are right, the failing CI checks are unrelated.
@ZMZ91 There is already some logic in the CSV reader to skip the BOM: https://github.com/apache/arrow/blob/fe9ca423f7f2684d70e0cf0cff8f48a0175c0fdf/cpp/src/arrow/csv/reader.cc#L109-L121 Instead of adding the same logic in the CSV parser, you should instead try to...
That is why your approach is wrong: the BOM is only expected at the beginning of the file, not at the beginning of each CSV cell.
CI failures are unrelated.
I'd like to give this a review before it gets merged, if possible. Le 10 août 2022 10:28:06 Sutou Kouhei ***@***.***> a écrit : > > @kou commented on this...
@kou I'll definitely review this.
In any case, I suggest we hold this up until the C++ version is switched to C++17 (see https://issues.apache.org/jira/browse/ARROW-17545).
> Though perhaps Antoine is suggesting that Arrow's close enough to requiring C++17 that the additional complications to the build process aren't worth the hassle? Yes, exactly this :-) >...
@nealrichardson Given the more pressing tasks for the 10.0.0 Arrow release, and the desire to not further disrupt the existing CI situation with the requirements of new third-party dependencies, I...