Antoine Pitrou

Results 822 comments of Antoine Pitrou

> (I guess these are mostly minor changes and we shouldn't need to restart the vote?) Yes, definitely. Also, sorry, the review contains C++ comments that I did some days/weeks...

I would be fine with `static_cast`. A 32-bit build cannot represent any in-memory containers larger than 2**32 elements (except perhaps a BooleanArray...).

ChunkedArray is still in-memory. For other places (such as file access) we might want to check.

While it is technically ok, I think sprinkling `static_cast` everywhere is both cumbersome (on the code writing _and_ reading sides) and will turn out fragile maintenance-wise. I also don't think...

Well, we _could_ selectively disable warnings in Arrow headers, but I fear that a lot of headers would probably be affected :-( Perhaps this needs to be further discussed on...

@naveensrinivasan Ping! Could you create a JIRA ticket as requested? If you are not able to do it, please say so so that someone else can step up :-)

For the record, we started [documenting](https://github.com/apache/arrow/blob/master/docs/source/cpp/parquet.rst#supported-parquet-features) the features supported by parquet-cpp (which is part of the Arrow codebase).

I'll note that the Arrow script that is being copied here received some later changes, but none seems mandatory for proper functionality. ``` $ git log --format=oneline --after=2020-01-28 dev/merge_arrow_pr.py 5eef8c399c9d5fa5f15289a5e12bd222135c6797...

@Fokko Is there anything left to do here? Otherwise it seems like this can be merged.

@ZJONSSON At the minimum, this should probably be discussed on the [dev mailing-list](https://mail-archives.apache.org/mod_mbox/parquet-dev/), and/or on a dedicated [JIRA issue](https://issues.apache.org/jira/browse/PARQUET). Since it has been 3 years since you posted this PR,...