Steve Pieper

Results 541 comments of Steve Pieper
trafficstars

Hi @ikhwanafath - I haven't had a chance to look at this - secondary captures are not something I've used dcmjs for, but I agree it would be good to...

Looks like @swederik added this, but I'm not sure what the reasoning was. https://github.com/dcmjs-org/dcmjs/blame/42a0a3d03b6eb14335e00392e0844c4bd41c50c5/src/normalizers.js#L294 Yes, we should certainly handle the case of a single slice segmentation because it does come...

Hi @jmhmd no, I don't think this has come up previously, so it's probably not implemented and yes, and example dataset would be helpful. I can't promise anyone can work...

That sounds great. 👍 You'll see that dcmjs has a minimal [test suite](https://github.com/dcmjs-org/dcmjs/blob/master/test/test_data.js) and it would be great to add something there. There's also the [data](https://github.com/dcmjs-org/data) repo to put the...

Sorry, I merged before reading this. I added you to the data repository. Having the test data will be great.

Thanks for reporting 👍 Can you provide an example file for testing? (ideally add it to https://github.com/dcmjs-org/data). p.s. Hi Forian, hope you are well!

Yes, a synthetic example would be fine. @swederik and I are also working on deid scripts in javascript - it would be fun to coordinate if possible.

Thank you - I've added the data as a release asset https://github.com/dcmjs-org/data/releases

@JamesAPetts can these `inPlane` statements be removed?

Good point - the relevant code is here: https://github.com/dcmjs-org/dcmjs/blob/master/src/DicomMetaDictionary.js#L220-L226 Looks like the problem is pretty well addressed here: https://stackoverflow.com/questions/105034/create-guid-uuid-in-javascript