Steve Pieper

icon indicating a website link http://www.isomics.com icon indicating an email [email protected]

icon company Isomics, Inc. icon location Cambridge, MA

Results 541 comments of Steve Pieper
trafficstars

Is there a way to force-read a file if the DICM Tag in the header is missing?

If you follow the metaheader link above you can see what needs to be in it. In this case it's the transfer syntax (format) of the data that needs to...

Enable a force write option for files with abnormal VRs

👋 @johndgiese and @ejcurtis - yes, I think if it's exposed in an options object with a name like `allowInvalidVRLength` that is false by default we should be fine. It's...

Enable a force write option for files with abnormal VRs

Sounds good @johndgiese. I've often thought we could do a json schema for this but never took it past the concept stage. Looking forward to seeing your editor someday.

Enable a force write option for files with abnormal VRs

Glad to see progress on this! It would be great if you could keep example instances that represent edge cases that need to be handled. So far we have [this...

feat: Add untilTag option to readFile

> `fromDirtyString` function is quite convenient True, but as a matter of style I'd like to encourage the use of the keywords from the data dictionary and keep the hex...

#84 WIP convert to binary instead of to utf8

Thanks for starting this. Since neither of us is sure if this is the overall correct answer I'm going to put this on the back burner. To move this forward...

Demo example does not work with a non-square image

Interestingly the first file IMG0001.dcm has no WindowCenter/WindowWidth tags so default is used and the image shows up black. If I just drop the other two files they show up...

code needs to be refactored

Also we should clean up any lingering dead code. Also any commented out (or not) console.log debug statements. Instead we should have a proper logging mechanism.

code needs to be refactored

loglevel looks fine to me. Also regarding DICOMZero, I'm thinking it should be made into a dcmjs.utils or similar.

code needs to be refactored

Hi Tobias - The helpers are not meant to be part of the main library, but if we find that there are specific methods in DICOMZero we could move them...