Steve Pieper

Results 541 comments of Steve Pieper
trafficstars

This looks really good @WoonchanCho 👍 I wonder if copying with attribution as you have done is the best approach as opposed to referencing an upstream package, whereby it might...

Those guys are both very good so It would be great to use their packages unless they don't have a chance to wrap things up and you need the features...

Yes, makes sense. Do you want to propose a fix?

Yes, that is good. There's been a lot of discussion about how best to handle RLE and bitpacked seg objects most efficiently.

There are no API docs currently, but contributions would be welcome. For now you should refer to the examples and tests to see how the code works.

Maybe this one would help: https://github.com/dcmjs-org/dcmjs-examples/blob/master/display/index.html

Thanks for the context 👍 I agree a test would help. Another small thing I think there cannot be a space between the `fix` and the `(` in the commit...

@wayfarer3130 can you comment on this PR to see if it's good to merge? Specifically how does it relate to #251 which seems to touch the same code.

Looks like the [metaheader](http://dicom.nema.org/medical/dicom/current/output/chtml/part10/chapter_7.html#sect_7.1) is missing. That's somewhat common and I know some other dicom software handles the missing metaheader automatically - perhaps dcmjs should as well, but it doesn't...