dcmjs icon indicating copy to clipboard operation
dcmjs copied to clipboard

Reading encapsulated pixel data?

Open jmhmd opened this issue 5 years ago • 5 comments
trafficstars

I'm trying to load a multiframe US with JPEG compression, and finding that only the first frame is loaded into the dataset. Is this my error or is loading encapsulated data with undefined length not supported yet? I can provide an example image if needed.

jmhmd avatar Aug 28 '20 19:08 jmhmd

Hi @jmhmd no, I don't think this has come up previously, so it's probably not implemented and yes, and example dataset would be helpful. I can't promise anyone can work on it unless it's in their personal critical path. Maybe it's not a big change if you step through in a debugger.

pieper avatar Aug 28 '20 20:08 pieper

I found what I think is the relevant code from dicomParser, so I may take a crack at porting it. It will probably need review when done by more experienced eyes.

jmhmd avatar Aug 28 '20 20:08 jmhmd

That sounds great. 👍

You'll see that dcmjs has a minimal test suite and it would be great to add something there. There's also the data repo to put the data.

pieper avatar Aug 28 '20 21:08 pieper

Hi @pieper, I have a pull request submitted (#147) which includes a simple test. I am not sure if I have permission to add a release on the data repo, but I do have a test instance which is referenced locally in the test. If you can help me get the file into the repo I can update the PR to use the remote data.

jmhmd avatar Sep 07 '20 19:09 jmhmd

Sorry, I merged before reading this. I added you to the data repository. Having the test data will be great.

pieper avatar Sep 10 '20 16:09 pieper