Steve Pieper

Results 541 comments of Steve Pieper
trafficstars

Nice, thanks for working on this 👍 Because it came up a lot in discourse posts and before that in the mailing list, I think we should stick with "Edit...

>> Because it came up a lot in discourse posts and before that in the mailing list, I think we should stick with "Edit -> Application Settings" instead of just...

Moving "Application Settings" to the bottom is not a problem for me. Changing to "Settings" would also not bother me much, but as I said I it seems like a...

I think the words are close enough that this hasn't been a source of confusion, but I agree it's better to be consistent and use Add.

Confirmed that changing to `vtkWarningMacro` allows the data to load as it did in previous versions. I will generate a gitlab merge request to the upstream VTK, but in the...

> Rationale for taking VTK file reading/errors seriously Agreed, we need to do pay attention to errors. I'm not suggesting we loosen anything, just be consistent and no worse than...

Yes, I'm aware they are captured, but they need to be reported in the log/console even if they aren't displayed in the GUI.

Even though I don't know if/when it will be accepted I created a VTK MR: https://gitlab.kitware.com/vtk/vtk/-/commit/7f768465185b4dbe04ab23de0a7a6034db4a2e61 I'll look a bit more to see what we can do at the Slicer...

> add a methods to make it easy to find and remove or re-classify certain messages Yes, that would be workaround. I'm torn though, since cherrypicking the change from VTK...

Agreed - thanks Jc! It's great to see the momentum on this and now is a good time to think through the options for automating as much of this as...