Peter Barker
Peter Barker
I find it surprising that we might go through cooldown if we detect 0 rpm (this is distinct from "no data")
> Similar to our EKF and Vibration status reporting, I think we should add an ESC health reporting label and pop-up window. The label should probably be white most of...
Some nice catches in there. I've been caught by B008 before.
We've merged fixes for the B006 and B008 problems. We don't have any protection for them coming back in again. How does one confidently move from bare-except and catching-Exception to...
> > Hi @harunkurtdev, > > Thanks for this. I actually didn't realise that Webots was still usable. Good news that it is. > > One thing is it would...
@harunkurtdev still waiting for some of my comments to be addressed
Just a note that upgrading numpy won't necessarily kill in-tree tools, but most definitely kills MAVProxy which is usually run in the same venv. This does suck.
> Based on the "too wildcardy" discussion in today's EU dev call, we should stop using `--ignore` to constrain the [pytest discovery rules](https://docs.pytest.org/en/stable/explanation/goodpractices.html#conventions-for-python-test-discovery) and instead use `testpaths` to focus pytest...
You're suggesting this message should be squelched, I assume :-)
So the story here is that unfortunately AP_TEMPERATURE_SENSOR_ENABLED is lying about whether the feature is built in. What's being detected there is a set of "dummy methods" we use to...