ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard
verified publisher icon ArduPilot

New Vehicle Heron USV for Webots

Open harunkurtdev opened this issue 1 year ago • 4 comments

heron_ocean

By connecting heron usv to ardupilot on webots. A new vehicle type has been added. This vehicle type is a marine vehicle and is well known in the market.

harunkurtdev avatar Sep 27 '24 22:09 harunkurtdev

Hi @harunkurtdev,

Thanks for this. I actually didn't realise that Webots was still usable. Good news that it is.

One thing is it would be best if the commits were squashed together somewhat and also if you peek at our commit history you'll see we always prefix commits with the subsystem (or folder) affected. This makes it easier for us to backport features.

rmackay9 avatar Sep 27 '24 23:09 rmackay9

Hi @harunkurtdev,

Thanks for this. I actually didn't realise that Webots was still usable. Good news that it is.

One thing is it would be best if the commits were squashed together somewhat and also if you peek at our commit history you'll see we always prefix commits with the subsystem (or folder) affected. This makes it easier for us to backport features.

So sir, what should I do? Can you recommend me a guideline?

I look this contributing

harunkurtdev avatar Sep 28 '24 09:09 harunkurtdev

Mr. @rmackay9, it is working, what should I do now? I did not add any file confusion that would prevent Ardupilot from working. Just new vehicle and world for webots.

harunkurtdev avatar Sep 28 '24 19:09 harunkurtdev

Hi @harunkurtdev, Thanks for this. I actually didn't realise that Webots was still usable. Good news that it is. One thing is it would be best if the commits were squashed together somewhat and also if you peek at our commit history you'll see we always prefix commits with the subsystem (or folder) affected. This makes it easier for us to backport features.

So sir, what should I do? Can you recommend me a guideline?

I look this contributing

The information you're after is here: https://ardupilot.org/dev/docs/git-interactive-rebase.html

peterbarker avatar Sep 29 '24 22:09 peterbarker

@harunkurtdev still waiting for some of my comments to be addressed

peterbarker avatar Nov 09 '24 00:11 peterbarker

@harunkurtdev still waiting for some of my comments to be addressed

Mr. @peterbarker,

I removed the parts you took into consideration and the unused parts.

Which part do I need to edit? Could you please state it again?

Sir, Are these what you've been waiting for?

https://github.com/ArduPilot/ardupilot/pull/28251#discussion_r1780193598 and https://github.com/ArduPilot/ardupilot/pull/28251#discussion_r1780193583

It just didn't work on WSL in Windows. I had added some to them but since it still didn't work and you told me to, I removed it.

harunkurtdev avatar Nov 10 '24 21:11 harunkurtdev