Dean Herbert
Dean Herbert
Probably need to do a reindex to handle such cases. I'm not sure if adding guest mappers triggers a reindex (or if some of the cases you mention are potentially...
Another case of logic not being copied across from old song select to allow non-animated scrolling. I'm aware of this but it's low priority.
> but the scenarios are weird enough that perhaps this should be properly fixed in a post-process that is fired after the user finishes editing beatmaps externally I'm not sure...
If you two can agree on a forward path here then I'm fine with that. Just make sure it's documented.
Would you be okay with the flash occurring in both directions (consistently) but no expansion changes happening? I think that would be my preferred behaviour.
I've fixed the issues pointed out. This changed some already tested behaviour, which has been updated. In the cases you found, there will now be no selection change.
> Steps are roughly: > > Start with the globally selected beatmap in one group > Apply filter wherein the globally selected beatmap is not in results > Start traversing...
This seems pretty critical / breaking. Bumping up pending investigation.
Also a touch concerned about performance of this given that we've seen the blur algorithm we're using perform pretty badly on some hardware already..
There's two ways to look at this. First of all we do have an eventual plan of caching the post-parsed beatmap content in `WorkingBeatmap`. This would help improve load time...