Dean Herbert comments

Results 1970 comments of


                                            Dean Herbert

Song Select V2: Updating a beatmap does not preserve selected beatmap

1. This would have been my preferred method – in fact I feel like I tried the same thing while working on the song select v2 implementation and may have...

Song Select V2: Updating a beatmap does not preserve selected beatmap

Should be closed via https://github.com/ppy/osu/pull/35240.

Refactor to command pattern for hit object change handling

@OliBomby is there a reason this is in draft state, or can we mark it ready for review?

Refactor to command pattern for hit object change handling

@OliBomby I'm going to take on review for this, but before I get too deep: - There looks to be a couple of tests still failing, can you check on...

Playback Resets To 1 Instead of 1.5 For NC Replays on Cutting Edge

I don't think this is important at all. It's also a cutting-edge only feature that is mostly there for us devs.

Song Select v2: beatmap carousel doesnt snap to unfiltered difficulty and jumps to random places when the selected difficulty is filtered

I'm not sure this can be improved. I guess we scroll to the set if available or something?

Song Select v2: beatmap carousel doesnt snap to unfiltered difficulty and jumps to random places when the selected difficulty is filtered

Should be better in the next release, see https://github.com/ppy/osu/pull/35179!

Song Select V2 : Shift + Enter should collapse groups while having a grouping filter enabled

Another shortcut I didn't realise existed.

Add bonus pp to UserStatistics API response object

We don't store this server-side, so it would be a relatively complex implementation (needs to be cached).

Automatically notify beatmap owners of new posts in their difficulty

Seems like something which should/could happen, for sure.