Dean Herbert
Dean Herbert
oops, wrong button here (fixed issue via https://github.com/peppy/osu/commit/584362efc3b25828663bdf894fb54f053d98bcc8).
I think it would probably be best to *always* show which version the score was set on (maybe including the build number?)
Can you include a screenshot for reference?
@bdach please double-check 187fa5eccd7309b7cde3645fb35896ed6fa81340, looks good otherwise.
Did you check performance with this? You're drawing the most expensive parts of the game all at the same time. There's very little chance this will stand up performance-wise.
> Forgot tests, sorry about that. Will add them in ASAP Seems back to front. Like you should be creating the tests to develop the feature. Adding as an afterthought...
I don't like this "simple" approach. Maybe simple for you, but not for a user. And also means you could potentially exit the skin editor or make edits in it...
To me this is an up-next feature. I've discussed with smoogi getting it attention sooner rather than later.
@smoogipoo is it save to assume the OP checklist is out of date? it seems like signing is handled in https://github.com/ppy/osu-auth-client/pull/63 and `osx-x64` is building?
Okay awesome, I'll test those.