Dean Herbert

Results 1970 comments of Dean Herbert

We saw this in the wild (a user report). Realm error: ``` 2024-03-26 08:04:17 [error]: Realms.Exceptions.RealmException: SetEndOfFile() failed: unknown error (1224) 2024-03-26 08:04:17 [error]: at Realms.NativeException.ThrowIfNecessary() 2024-03-26 08:04:17 [error]: at...

@nirinchev precisely, yes. we're now [working around this](https://github.com/ppy/osu/pull/28785/files#diff-cec92312767dde13b199169357d1373be9ae90864695e4ccfdd445cb10f98f28R295-R312) in a very simple fashion, which looks to be working well.

Also very curious about the tight performance requirements here. I did my own benchmarking of property access before we considered migrating to realm (https://github.com/ppy/osu/issues/7057 search for "Property retrival via realm")...

Thanks for the benchmark code! I actually found an oversight in my original benchmarks when comparing (the "unmanaged" objects I was benchmarking were actually being managed). Your results look correct...

Very hard to say without looking into detail, but do consider that you're looking at nanosecond values here. It seems to stabilise at all your tests above 1-10 count runs...

Thanks for your contribution. That said, I would highly recommend asking before submitting relatively complex fixes for features recently released by core team members. On principle, if this is not...

> The CodeFactor failure wasn't from my changes, I'm not sure what the right `carouselItems?.Any() != true` equivalent is, `carouselItems == null || carouselItems.Count == 0`? codefactor can generally be...

I'm going to review this. I've started by (hopefully) rebasing the changes on top of latest `master`.

Added this as closing https://github.com/ppy/osu/issues/33512 as well, as it looks like it should. Will ensure test coverage is added for rulesets.

Closing this as the implementation was wrong in too many ways. New PR will arrive soon.