Robert Pająk

Results 705 comments of Robert Pająk
trafficstars

SIG meeting: - during the bootstrapping/initialization we can handle all exceptions. The .NET runtime handles `OutOfMemoryException`, `StackoverflowExcception` etc in a special way so it will not be caught by `catch`....

This seems inline with this proposal: https://github.com/dotnet/runtime/issues/66138#issuecomment-1071045008

> If application has higher version of OpenTelemetry SDK than the Auto-Instrumentation OpenTelemetry SDK. Higher version wins and if there are breaking changes between these versions, auto-instrumentation might affect an...

My biggest worry about creating a NuGet package is that as the number of "source instrumentation" grows the more dependencies we will bring and it may lead to dependency hell....

**SIG meeting notes** Check how .NET SDK does it and try to keep it in line. We can consider to work on it in several steps: 1. Add support in...

Related comment: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/458#discussion_r844601916

SIG meeting notes: Nice to have for beta (not must have).

**SIG meeting** @nrcventura to describe it better post-beta

**Actual behaviour** The application crashed with ``` Unhandled exception. System.OverflowException: Arithmetic operation resulted in an overflow. at DDVoidMethodType.DDVoidMethodCall() at Microsoft.DotNet.Cli.Program.Main(String[] args) ```

@pjanotti The bug is still there: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/1cb8c5ededad090c78df93dea3980b8626387eb5/src/OpenTelemetry.ClrProfiler.Native/cor_profiler.cpp#L2960 As far as I understand the code the loader assembly is not properly read because `OpenTelemetry.ClrProfiler.Native.dylib` is hardcoded. It results in `assemblySize`, `pAssemblyArray`,...