Robert Pająk

Results 706 comments of Robert Pająk
trafficstars

A custom assembly resolver could conflict with a user-defined assembly resolver. It would have to be possible to disable this functionality. When it would be disabled (because the user has...

Now it fails like this: - https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/runs/7553815148?check_suite_focus=true - https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/runs/7556338386?check_suite_focus=true > Did not expect any exceptions after 30s, but found System.Net.Http.HttpRequestException with message "Connection refused"

This one looks interesting: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/runs/7549934722?check_suite_focus=true ``` IntegrationTests.SmokeTests.PrometheusExporter [FAIL] Failed IntegrationTests.SmokeTests.PrometheusExporter [30 s] Error Message: Did not expect any exceptions after 30s, but found Xunit.Sdk.XunitException with message "Expected content " #...

From my "spec reading" understanding is that the first rule (regarding enum values parsing) overrides the second (regarding initialization error handling) as: - `MUST` is stronger than `MAY` - it...

PR created https://github.com/open-telemetry/opentelemetry-specification/pull/2766

Quick idea: [Microsoft.AspNetCore.Http.Abstractions](https://www.nuget.org/packages/Microsoft.AspNetCore.Http.Abstractions/) and [Microsoft.AspNetCore.Http.Features](https://www.nuget.org/packages/Microsoft.AspNetCore.Http.Features/) to additional dependencies or/and even auto-instrumentation "output" (so that it works for .NET Framework as well). Reference: https://www.nuget.org/packages/OpenTelemetry.Instrumentation.AspNetCore/1.0.0-rc9.4#dependencies-body-tab

PR in SDK: https://github.com/open-telemetry/opentelemetry-dotnet/pull/3424

We are waiting for an SDK release to have it integrated.

The env var should be named `OTEL_EXPORTER_ZIPKIN_TIMEOUT` Maybe this should be supported by the SDK?

The env vars should be named: - `OTEL_EXPORTER_OTLP_TIMEOUT` - `OTEL_EXPORTER_OTLP_TRACES_TIMEOUT` - `OTEL_EXPORTER_OTLP_METRICS_TIMEOUT` Reference: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options Maybe this should be supported by the SDK?