Robert Pająk

Results 363 comments of Robert Pająk

This is about supporting the scenario where the customer does not have access to the build.

Related issue https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/issues/323

My opinion ad. 1. Yes. OTLP exporter does not do any [transformations](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md) so the assertions would be more trustworthy. ad. 2. We can have only some integration tests to test...

> We'll eventually need to decide if we want the tests to be grpc based, or http based. I strongly prefer to use `grpc` as this is the default in...

We ended up in `http/protobuf` per https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/issues/325

I advise you to consider joining the SIG meeting to present the PR and ask for feedback. You can also ask for reviews on Slack. See: https://github.com/open-telemetry/opentelemetry-go/blob/main/CONTRIBUTING.md The comments I...

``` go: updates to go.mod needed; to update it: go mod tidy ```

@open-telemetry/go-maintainers PTAL

Side note: shouldn't we consider moving the library instrumentation [here](https://github.com/go-kit/kit/tree/master/tracing) per > we have the following recommendations for where instrumentation packages should live. > > 1. Native to the instrumented...

@kweitb Generally the code looks OK but I am not sure it would not be better to use `Sampler` which filter's out span's without a parent. Have you checked `Sampler`...