Robert Pająk
Robert Pająk
I updated the `CHANGELOG.md`.
For the executable script, I suggest vendoring it instead. Thanks to it the build will not magically fail if the content changes. This is how it is done in `setup-dotnet`...
Some span is captured but it does not have the expected attribute: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/actions/runs/3097103461/jobs/5013412328
If the impact will be noticeable we could introduce an env var to control it. However, I would rather not do it as it is just about longer initialization. Probably...
@pjanotti I am not sure if this issue should be closed. The issue reported by @muhaook was reported (and closed) here: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/issues/1117 This issue is about adding generic bytecode instrumentation...
I triggered `verify-test`: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/actions/runs/3082544603
Passed. Congratulations @Kielek 🎉 Closing
I have a strong feeling that this is a bug in the SDK. Take notice: https://github.com/open-telemetry/opentelemetry-dotnet/blob/46e6c8a06d4485a67e2a17afe10272cdb1a7b3ee/test/OpenTelemetry.Exporter.Prometheus.Tests/PrometheusCollectionManagerTests.cs#L33
https://github.com/open-telemetry/opentelemetry-dotnet/issues/3679
@RassK Still seems to be flaky https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/actions/runs/3104529499/jobs/5029565093#step:4:2665