opentelemetry-dotnet-instrumentation icon indicating copy to clipboard operation
opentelemetry-dotnet-instrumentation copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Add tests for environment helpers

Open pjanotti opened this issue 3 years ago • 1 comments
trafficstars

There are enough behavior behind the environment helpers, especially SetExporter, to justify dedicated unit tests. The tests should cover:

  • EnvironmentConfigurationMetricHelper
  • EnvironmentConfigurationTracerHelper

pjanotti avatar May 31 '22 23:05 pjanotti

@pjanotti Do you expect any more tests than we have right now (mostly thanks to https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/845)? I think we have integration tests for testing these classes - anything other than them would be very artificial.

pellared avatar Jun 22 '22 16:06 pellared

@pellared this issue was opened when I was doing https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/708 - the helper was not working as intended and there were no tests covering it. Now they are covered via integration tests as you said. Taking that into account I don't think we need this anymore.

pjanotti avatar Aug 11 '22 02:08 pjanotti