pandaaaBE

Results 36 comments of pandaaaBE

Why is this pr not merged? is something wrong?

Why are you not creating a class (e.g. Smelting.php) and you store Fuel and XP. Fuel has maybe 25 items+ and XP has maybe 40 items+.

![image](https://github.com/pmmp/PocketMine-MP/assets/135014092/ba60b41a-a1a6-492d-8dca-9ef989801ceb) Looks finished now :)

the only problem left is that the re-generated actual-problems.neon removes following thing: ``` - message: "#^Parameter \\#1 \\$logFile of class pocketmine\\\\utils\\\\MainLogger constructor expects string, string\\|false given\\.$#" count: 1 path: ../../phpunit/scheduler/AsyncPoolTest.php...

Is this pr finished or is something left? I ask because of the Label

> At the moment I'm still dubious about the fact that the API has been implemented right down to the NPC itself. > > > > Is this a mission...

Is it enough if it stays as it is now (as I said, there are no mobs) or should I add the Horse Armor to Living::attack() anyway?

> You need to regenerate the static functions for whatever reason i can't run the file on my laptop. can do that when i am back at the pc 👌

![image](https://github.com/pmmp/PocketMine-MP/assets/135014092/94e5a420-87aa-4f39-ae9e-daf4bf0b8419) Is it enough if it stays as it is now (as I said, there are no mobs) or should I do more?

> Cauldron behaviour is also missing. In vanilla, leather armour can be dyed in cauldron. Jup but this is currently not implemented in pocketmine and I don´t feel like it...