Implement missing Nether Blocks
Introduction
This plugin adds follow things:
- Crimson Nylium/Fungus, Waped Nylium/Fungus, Nether Sporuts
- Bone Meal Logic for Netherrack
- Adds support for Nylium to Mushrooms
- Adds support for Nylium to NetherRoots
Note: Bone Meal logic for Fungus is currently missing and is not planned in this pull request
Project Card: https://github.com/pmmp/PocketMine-MP/projects/14#card-84464878
(reopened due of unresolved conflicts of the old pr)
Changes
API changes
VanillaBlocks::CRIMSON_NYLIUM(), VanillaBlocks::WARPED_NYLIUM(), VanillaBlocks::CRIMSON_FUNGUS(), VanillaBlocks::WARPED_FUNGUS(), VanillaBlocks::NETHER_SPROUTS()
Tests
I tested this PR by doing the following (tick all that apply):
- [x] Writing PHPUnit tests (commit these in the
tests/phpunitfolder) - [x] Playtesting using a Minecraft client (provide screenshots or a video)
the only problem left is that the re-generated actual-problems.neon removes following thing:
-
message: "#^Parameter \\#1 \\$logFile of class pocketmine\\\\utils\\\\MainLogger constructor expects string, string\\|false given\\.$#"
count: 1
path: ../../phpunit/scheduler/AsyncPoolTest.php
Should I just copy & paste it in the file? lol
Is this pr finished or is something left? I ask because of the Label
Should be ready for a final review
Any idea how to resolve this conflicts?
Resolve and regenerate the block_factory_consistency