PocketMine-MP icon indicating copy to clipboard operation
PocketMine-MP copied to clipboard

Implemented smithing table functionality

Open HimmelKreis4865 opened this issue 8 months ago • 4 comments

Introduction

This PR adds working smithing tables to pocketmine. There are no known issues or problems

Changes

API changes

Amor->setTrim(ArmorTrim) Armor->getTrim() : ?ArmorTrim Armor->clearTrim()

SmithingTableInventory->getInput() : Item SmithingTableInventory->getAddition() : Item SmithingTableInventory->getTemplate() : Item

The new enums: ArmorTrimPattern & ArmorTrimMaterial (required to construct ArmorTrim)

Tests

Tested ingame with the smithing table several times: image

Tested the code

$player->getInventory()->addItem(VanillaItems::LEATHER_CAP()->setTrim(new ArmorTrim(ArmorTrimMaterial::QUARTZ, ArmorTrimPattern::EYE)));

HimmelKreis4865 avatar Dec 18 '23 13:12 HimmelKreis4865

There's not much more I can do at this point, everthing is fixed except for save ids.

HimmelKreis4865 avatar Jan 23 '24 20:01 HimmelKreis4865

how do I put this on my server?

fractalllll avatar Mar 10 '24 17:03 fractalllll

image Looks finished now :)

pandaa-be avatar Mar 22 '24 17:03 pandaa-be

yeah, ready to be reviewed again.

HimmelKreis4865 avatar Mar 22 '24 17:03 HimmelKreis4865