pandaaaBE

Results 36 comments of pandaaaBE

> what is still missing? nothing. just reviews 😭

Should be ready for a final review

Any idea how to resolve this conflicts?

Waiting for more pm member to approve this little pr

I think this PR is finished

> This implementation is missing interaction with the Cauldron. See The interaction between Armor and the cauldron here for an implementation guide: https://github.com/pmmp/PocketMine-MP/blob/stable/src/block/WaterCauldron.php#L132-L148 wdym? it is implemented ![image](https://github.com/pmmp/PocketMine-MP/assets/135014092/afaacc54-a204-42e9-bde2-f9eb9b6c2acc)

Now I have renamed the old HorseArmor.php file to LeatherHorseArmor.php xd

> I'm still thinking about the fact that basic armour has no way of being easily detected. If a plugin wants to add the horse interface for example, it will...

So, I asked again on the Discord and an extra class for the Horse Armor doesn't seem to be necessary - although the duplicated code is annoying... If you still...