Petrik de Heus
Petrik de Heus
I'm not sure the following is still correct: ```markdown In order to validate associated records whose presence is required, you must specify the `:inverse_of` option for the association: ``` I'll...
Is the line `The gateway through which you can drill down into various details of each error` maybe a bit too cryptic? Maybe remove that line and replace `This` with...
The example in the following section comes a bit abrupt (Github doesn't allow adding suggestions to this section so I'm adding this as a separate comment): ````markdown `where` returns an...
> @p8 it seems from research maybe this is true instead: > > To validate associated records whose presence is required, Rails will usually infer the inverse association automatically. However,...
The GoodnessValidator doesn't seem like a typical validator. Maybe replace it with an AddressValidator? ````markdown ```ruby class AddressValidator < ActiveModel::Validator def validate(record) if record.house_number.blank? record.errors.add :house_number, "is required" end if...
Some last nitpicks: For the `confirmation` validator `helper` is used instead of `validator`. https://github.com/rails/rails/blob/79db91dca7a17e3173796a0712b4bd9812e7d0e4/guides/source/active_record_validations.md?plain=1#L511 For the `comparison` validator `check` is used instead of `validator`. https://github.com/rails/rails/blob/79db91dca7a17e3173796a0712b4bd9812e7d0e4/guides/source/active_record_validations.md?plain=1#L568 For the `format` validator `helper`...
@hachi8833 Thanks for mentioning this! I've backported it in: https://github.com/rails/rails/pull/54035
> Upon reviewing the changes, I notice that some information that was previously present is now missing. In particular, the whole section about using UUIDs is no longer there, and...
Thanks for working on this 👍🏼 Will there be a composite score as well? I use it a lot to see if changes are an improvement.
Would it make sense to make the fortunes tests the first tab, as it seems to be the default when opening the results.