Mariusz Zaborski

Results 64 comments of Mariusz Zaborski

Yes, it looks much better. I will build it and test and let you know if it runs as expected.

``` usr.bin/lsvfs/lsvfs.c:67:18: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare] 67 | for (j = 0; j < argc; j++) { | ~ ^...

Commited: a0c709ab5af4e87ce4579404c4ffbd4295ad12c5

> from(1): Remove braces from single-line conditional statements for consistency to meet style(9) compliance +1. > from(1): Add blank line after kernel include files to meet style(9) compliance > from(1):...

One more thing :) > Add missing include file Why actually we need `errno.h`? It's unclear for me from the commit msg and from the code.

> But I'd drop: > from(1): Remove braces from single-line conditional statements for consistency to meet style(9) compliance This one was not dropped. But I guess I can omit while...

> I am fine with you omitting it, but I still believe updating non-compliant statements to meet style(9) would help maintain consistency and promote adherence to the standard, so my...

Hello, I have not released the packages. However, CI already works on Ghidra 11.0. You can grab the last build [here](https://github.com/oshogbo/ghidra-lx-loader/actions/runs/8156630300) or direct [link to zip](https://github.com/oshogbo/ghidra-lx-loader/actions/runs/8156630300/artifacts/1298440485).

@kfv Can you also fix the style issues reported by GitHub Actions?