freebsd-src look(1): Capsicumise

Oct 24 '24 21:10 kfv

@oshogbo can you review this?

Oct 25 '24 22:10 lwhsu

@kfv Can you also fix the style issues reported by GitHub Actions?

Oct 31 '24 11:10 oshogbo

@oshogbo: The style checks are already passing, but I assume you're referring to the warnings for lines exceeding 80 characters. I’ll go ahead and address those as well, sure.

Nov 01 '24 09:11 kfv

@oshogbo: I applied soft wrapping but kept mmap() on line 162 unwrapped for clarity. I also removed WITHOUT_CAPSICUM by handling ENOSYS as suggested. I’ll just need to go over the code again to address the dynamic stack allocation we discussed.

Nov 01 '24 10:11 kfv

Sorry, why haven't we used capsicum_helpers here?

Nov 27 '24 12:11 oshogbo

@markjdb any final comments?

Jun 12 '25 00:06 bsdimp

@markjdb any final comments?

@oshogbo 's comments still apply here: these should just use capsicum helpers (i.e., caph_* routines which handle ENOSYS), and the dynamically allocated stack array is kind of iffy and should be converted to an explicit allocation.

Jun 12 '25 00:06 markjdb

@kfv What are your plans here? This seems to be stuck waiting for addressing the helper feedback comments.

Aug 04 '25 19:08 bsdimp

Hi, apologies for the extended delay in addressing the requested changes. The past year has been personally and geopolitically challenging, and I appreciate your patience. I make sure to go through all the pending requests within the coming week at most. Thank you again for your understanding.

Aug 04 '25 22:08 kfv

I think this is ready for final review. Let me know if I’ve missed anything or if there’s anything else you'd like me to adjust.

Aug 06 '25 12:08 kfv

What do you think @markjdb and @bsdimp ?

Aug 19 '25 08:08 oshogbo