Mariusz Zaborski

Results 64 comments of Mariusz Zaborski

Sorry, why haven't we used capsicum_helpers here?

What do you think @markjdb and @bsdimp ?

@anjalirai-intel Thank you for reporting. This update should fix your issue.

Yes, it's not problem with the code, as I have tested it in PR as well, and it builded correctly. I have tried to re run the build. Let's see...

Yes. It seems to work now :)

> Forgot to mention this earlier - can you add a test case to exercise zpool scrub -S|-E? Please include all weird edge cases, like invalid dates/ranges, setting timezones forward/backwards,...

Can we re-run the tests? It seems they have timed out. I don’t see any indication of an error, at least for now.

I think everything should be fixed now.

I have addressed the feedback.

> What is the user experience like here if their clock changes? It seems like because of the linear search we will always find the first time interval in each...