freebsd
lsvfs(1): Capsicumise
We don't need to change Makefile to add casper support?
You're right; I had changed it but forgot to commit. My apologies.
Hi, apologies for the extended delay in addressing the requested changes. The past year has been personally and geopolitically challenging, and I appreciate your patience. I make sure to go through all the pending requests within the coming week at most. Thank you again for your understanding.
@oshogbo: I’m pretty sure we’re finally ready to ship the Capsicumise commit as well. I’ve completely reworked it since it had some issues. Thanks a lot for catching that and for bearing with my slip-ups. It’s been a great journey!
@oshogbo: Reworked this based on your feedback (and also shared some thoughts on the thread). Sorry for the delay — I was away on vacation.
This version now fetches the full vfs.conflist list up front, then enters capability mode before any filtering/printing. That way sandboxing is meaningful, while keeping the overall approach close to what we had with getvfsbyname, but done manually here without further sysctl calls under the hood.
Could you take a look and let me know what you think?
Yes, it looks much better. I will build it and test and let you know if it runs as expected.
usr.bin/lsvfs/lsvfs.c:67:18: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
67 | for (j = 0; j < argc; j++) {
| ~ ^ ~~~~
usr.bin/lsvfs/lsvfs.c:71:10: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
71 | if (j == argc)
| ~ ^ ~~~~
2 errors generated.
*** Error code 1
Right, j should have been declared as int since it is compared against argc. My apologies for the oversight.