freebsd-src icon indicating copy to clipboard operation
freebsd-src copied to clipboard

cap_fileargs.3: Comprehensive rewrite for improved clarity and accuracy

Open kfv opened this issue 1 year ago • 8 comments

Extensively revised the manual page with clearer phrasing, better structure, and corrected grammar throughout. Also fixed multiple typos and improved overall readability of the documentation.

kfv avatar Dec 14 '24 15:12 kfv

Cc: @oshogbo

kfv avatar Dec 14 '24 15:12 kfv

I don't think this was the commit you intended to push?

concussious avatar Dec 15 '24 20:12 concussious

How come?

kfv avatar Dec 15 '24 22:12 kfv

By the way, I’m sorry if I forgot to thank you. It’s been a tough day, and I can’t even remember how I managed to handle the changes you requested.

kfv avatar Dec 15 '24 22:12 kfv

How come?

The commits appear to be unchanged.

By the way, I’m sorry if I forgot to thank you.

Hey, likewise. Improvements to the manual excite me.

concussious avatar Dec 17 '24 03:12 concussious

Whoops! I'll take a look in an hour. I might have missed something.

kfv avatar Dec 17 '24 08:12 kfv

You were right, mate. Requested changes are now pushed. Please take a look and let me know if anything else is necessary to consider and apply.

kfv avatar Dec 17 '24 10:12 kfv

When I make this type of commit, I usually will title it something like "cap_fileargs.3: Polish". This is a wonderful and necessary review and editorial pass, but a comprehensive rewrite is a different type of thing.

concussious avatar Feb 20 '25 16:02 concussious

@asomers @markjdb @oshogbo Any final comments? Looks like there's a few unresolved comments still, but they look minor. @kfv Anything else?

bsdimp avatar Aug 04 '25 19:08 bsdimp

Hi, apologies for the extended delay in addressing the requested changes. The past year has been personally and geopolitically challenging, and I appreciate your patience. I make sure to go through all the pending requests within the coming week at most. Thank you again for your understanding.

kfv avatar Aug 04 '25 22:08 kfv

@bsdimp: Ready to ship.

kfv avatar Aug 05 '25 12:08 kfv

Hey while you're here, .Sh LIBRARY is deprecated in the current version of mandoc. Can you remove it, and move the .Lb macro to the top of SYNOPSIS?

I didn't know, thanks! Done, mate.

kfv avatar Aug 05 '25 14:08 kfv

I have committed it as 50dee972977a

oshogbo avatar Aug 08 '25 16:08 oshogbo