Oscar Gustafsson comments

Results 474 comments of


                                            Oscar Gustafsson

Fix some Vivado issues (SystemVerilog support, space in file name, environment variable)

Sorry for letting this slip. Will try to find some time "soon" to complete it.

Fix some Vivado issues (SystemVerilog support, space in file name, environment variable)

Finally got around to this. Not sure this is exactly what you wanted, but at least a "Tool Integration" menu item and then Vivado shows up there. Not clear to...

Fix some Vivado issues (SystemVerilog support, space in file name, environment variable)

I'll see what I can do in terms of splitting it. It's been a while.

Fix issues when trying to parameterize Verilog modules

I think it maybe is better to either: 1. Move the case-handling to `get_test_bench` 2. Do try-except on `get_test_bench` only and then only check `KeyError`.

Fix issues when trying to parameterize Verilog modules

Thanks! (I should probably have mentioned that I cannot approve or merge anything, but I think/hope that the suggested changes increases the chance of having it merged...)

Fix issues when trying to parameterize Verilog modules

I can try to ping in @LarsAsplund and @kraigher . My impression is that they have been quite busy recently though. (There may be other people that have the correct...

subplots() returns AxesArray

Is the idea to support "broadcasting" of the `Axes` method? Like `AxisArray().set_xlim` etc?

Update `_unpack_to_numpy` function to convert JAX and PyTorch arrays to NumPy

Hmm, it seems like this is probably the clearest indication of the test failures: ``` > assert ax1.xaxis.get_units() == ax2.xaxis.get_units() == "hours" E AssertionError: assert None == 'hours' ``` As...

Update `_unpack_to_numpy` function to convert JAX and PyTorch arrays to NumPy

Do not trust this fully, but I think that checking if there is a `numpy` method and then calling that (and checking the output) would probably make sense and solve...

Support sharing cycler instances across axes

Since I just opened an issue about this (before searching...), let me chip in my use case, which I think is slightly different. I have twinned axes and a function...